-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager] Adjust dataset aggs to use datastream fields instead #74342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elastic Agent and Elasticsearch are switching over from using dataset.* to datastream.*. This adjust the aggregation on the dataset page to get the datastreams. For this to work properly, the most recent version of Elasticsearch 7.9 must be used and is pending updates on all the packages to ship also the datastream fields, see elastic/integrations#213
skh
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.10.0
v7.9.0
v8.0.0
labels
Aug 5, 2020
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
Pinging @elastic/ingest-management (Team:Ingest Management) |
ruflin
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did run this against Elasticsearch 8.0 with Agent 8.0 and things work as expected.
skh
added a commit
to skh/kibana
that referenced
this pull request
Aug 5, 2020
…elastic#74342) * [Ingest Manager] Adjust dataset aggs to use datastream fields instead Elastic Agent and Elasticsearch are switching over from using dataset.* to datastream.*. This adjust the aggregation on the dataset page to get the datastreams. For this to work properly, the most recent version of Elasticsearch 7.9 must be used and is pending updates on all the packages to ship also the datastream fields, see elastic/integrations#213 * Update datastream to data_stream * Update data stream name generation * Fix typo * Temporarily use datastream instead of data_stream * updating to use `data_stream` instead of `datastream` Co-authored-by: ruflin <spam@ruflin.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
skh
added a commit
to skh/kibana
that referenced
this pull request
Aug 5, 2020
…elastic#74342) * [Ingest Manager] Adjust dataset aggs to use datastream fields instead Elastic Agent and Elasticsearch are switching over from using dataset.* to datastream.*. This adjust the aggregation on the dataset page to get the datastreams. For this to work properly, the most recent version of Elasticsearch 7.9 must be used and is pending updates on all the packages to ship also the datastream fields, see elastic/integrations#213 * Update datastream to data_stream * Update data stream name generation * Fix typo * Temporarily use datastream instead of data_stream * updating to use `data_stream` instead of `datastream` Co-authored-by: ruflin <spam@ruflin.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
skh
added a commit
that referenced
this pull request
Aug 5, 2020
…#74342) (#74355) * [Ingest Manager] Adjust dataset aggs to use datastream fields instead Elastic Agent and Elasticsearch are switching over from using dataset.* to datastream.*. This adjust the aggregation on the dataset page to get the datastreams. For this to work properly, the most recent version of Elasticsearch 7.9 must be used and is pending updates on all the packages to ship also the datastream fields, see elastic/integrations#213 * Update datastream to data_stream * Update data stream name generation * Fix typo * Temporarily use datastream instead of data_stream * updating to use `data_stream` instead of `datastream` Co-authored-by: ruflin <spam@ruflin.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com> Co-authored-by: ruflin <spam@ruflin.com> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
ruflin
pushed a commit
that referenced
this pull request
Aug 5, 2020
…#74342) (#74356) Elastic Agent and Elasticsearch are switching over from using dataset.* to datastream.*. This adjust the aggregation on the dataset page to get the datastreams. For this to work properly, the most recent version of Elasticsearch 7.9 must be used and is pending updates on all the packages to ship also the datastream fields, see elastic/integrations#213
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 5, 2020
* master: update docs (elastic#74364) [Ingest Node Pipelines] Refactor pipeline simulator code (elastic#72328) Add README files for Kibana app plugins (elastic#74277) [APM] Average for transaction error rate includes null values (elastic#74345) [Ingest Manager] Adjust dataset aggs to use datastream fields instead (elastic#74342)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.9.0
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a remake of #74226 against
master
. Implements #74257Elastic Agent and Elasticsearch are switching over from using dataset.* to data_stream.*. This adjust the aggregation on the dataset page to get the data_streams.
For this to work properly, the most recent version of Elasticsearch 7.9 must be used and is pending updates on all the packages to ship also the data_stream fields, see elastic/integrations#213 and elastic/elasticsearch#60715